fix(lyrics-plus): seperate translated lyrics providers from mode selection #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into force-lang2
Deskehs
changed the title
ohitstom
reviewed
May 8, 2023
|
I kind of need some help here. As I don't have much React experience I do not know how would I switch state between the translated lyrics from the provider and the page's original lyrics without overriding them and then run the translate function without going into a loop or cause some kind of overflow. This sucks, I might need to look at React docs and experiment with some ideas. |
Co-authored-by: Nam Anh <[email protected]>
…into force-lang2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was supposed to allow Netease translated lyrics covert to Traditional Chinese.
However, in the future if Musixmatch translated lyrics are supported, they can also (for example in Japanese) convert to furigana.
This PR also updates the language detection algorithm a bit, allowing detection override and some fixes and one-liner changes.
NOT COMPLETE: just need to figure how to run the translate function and dropdown update after change